-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix reading from sparse columns after restart #49660
Fix reading from sparse columns after restart #49660
Conversation
This is an automated comment for commit 996fcfe with description of existing statuses. It's updated for the latest CI running
|
SerializationInfoByName infos(loaded_columns, settings); | ||
SerializationInfoByName infos; | ||
if (metadata_manager->exists(SERIALIZATION_FILE_NAME)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is it intended that now if in line 1345 condition is not satisfied then infos is not initialised?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it's ok. If SerializationInfoByName
is not initialized the default serialization will be returned for all columns. It's what expected.
The test |
Need to backport it to 23.3 to be able to downgrade from the versions with enabled ratio_of_defaults_for_sparse_serialization |
…eload Fix reading from sparse columns after restart
…eload Fix reading from sparse columns after restart
…-columns-reload 23.3 Backport of ClickHouse#49660 - fix sparse columns reload
…0481493005e5d23f437c222e7f362 Cherry pick #49660 to 23.3: Fix reading from sparse columns after restart
Backport #49660 to 23.3: Fix reading from sparse columns after restart
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fixed reading from sparse columns after changing setting
ratio_of_defaults_for_sparse_serialization
back to1.0
and restart of server.